• grrgyle@slrpnk.net
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        Principle developer tip: rewrite history to make yourself seem smarter.

        Soft reset the whole branch and commit a series of atomic and semantic patches (eg separating code, test, and refactor changes) that tell a clean narrative of the changeset to reviewers, future blamers.

  • seaQueue@lemmy.world
    link
    fedilink
    arrow-up
    3
    ·
    3 months ago

    It’s a picture of the people who submit zero value comment spelling fixes to the Linux kernel so they can claim “I’ve submitted X patches to the Linux kernel” for KPIs or resume building

    • tourist@lemmy.world
      link
      fedilink
      arrow-up
      2
      ·
      3 months ago

      “Hey Bob, you’ve worked on the Linux kernel before, can you handle this CPU scheduler problem we’re having? Shouldn’t take you too long. We need it done before lunch”

    • gravitas_deficiency@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      3 months ago

      Hey man, I once had an engineering exec (who didn’t last very long) who decided engineers would be stack ranked by SLOC. You can imagine how easy that metric was to cheese, and you can also imagine exactly how that policy turned out.

      Give an engineer a stupid metric to meet, and they’ll find a stupid way to meet it for you, if only out of malicious compliance.

    • JackbyDev@programming.dev
      link
      fedilink
      English
      arrow-up
      1
      ·
      3 months ago

      Any standard that wastes valuable space in the first line of the commit is a hard sell. I don’t see the point in including fix/feat/feat! just for the sake of “easy” semantic versioning because generally you know if the next release is going to be major or minor and patches are generally only only after specific bugs. Scanning the commits like this also puts way too much trust in people writing good commit messages which nobody ever seems to do.

      Also, I fucking hate standards that use generic names like this. It’s like they’re declaring themselves the correct choice. Like “git flow”.

      • mariusafa@lemmy.sdf.org
        link
        fedilink
        arrow-up
        0
        ·
        3 months ago

        You can always adapt to your how repo. But yeah, that’s the point. If you can trust people to make changes on a repo then you should be able to trust them in using some kind of commit structure.

        Generic names are probably used in order to crate a familiar, easy to remember, structurized commit format.

        • JackbyDev@programming.dev
          link
          fedilink
          English
          arrow-up
          0
          arrow-down
          1
          ·
          3 months ago

          The generic name I’m complaining about is “conventional commits”, not “fix” and “feat”

    • efstajas@lemmy.world
      link
      fedilink
      arrow-up
      1
      ·
      edit-2
      3 months ago

      Honestly, I’ve worked with a few teams that use conventional commits, some even enforcing it through CI, and I don’t think I’ve ever thought “damn, I’m glad we’re doing this”. Granted, all the teams I’ve been on were working on user facing products with rolling release where main always = prod, and there was zero need for auto-generating changelogs, or analyzing the git history in any way. In my experience, trying to roughly follow 1 feature / change per PR and then just squash-merging PRs to main is really just … totally fine, if that’s what you’re doing.

      I guess what I’m trying to say is that while conv commits are neat and all, the overhead really isn’t really always worth it. If you’re developing an SDK or OSS package and you need changelogs, sure. Other than that, really, what’s the point?

      • mariusafa@lemmy.sdf.org
        link
        fedilink
        arrow-up
        0
        arrow-down
        1
        ·
        3 months ago

        You can always water it down. The point is to have some order in the commits. Otherwise is just messy.

  • onlinepersona@programming.dev
    link
    fedilink
    English
    arrow-up
    0
    arrow-down
    1
    ·
    edit-2
    3 months ago

    Sometimes I’m in awe at the effort people put into these memes. Well done 😄

    P.S Now make one about people who squash 100 commits into one without cleaning up the message and have a single commit with 1k added / 2k removed in it for the sake of “clean” history.

    Anti Commercial-AI license