• blaue_Fledermaus@mstdn.io
      link
      fedilink
      arrow-up
      36
      ·
      1 month ago

      Static types are great, but not exactly what would have helped here, any decent language or at least a linter should catch the use of a not declared identifier.

        • UndercoverUlrikHD@programming.dev
          link
          fedilink
          arrow-up
          16
          ·
          1 month ago
          class MyClass:
              def __init__(self, x: int):
                  self.whatever: int = x
          
          def foo(x: MyClass) -> int:
              return x.whatevr
          

          Any decent IDE would give you an error for unresolved attribute. Likewise it would warn you of type error if the type of x.whatever didn’t match the return type of foo()

          • Starbuncle@lemmy.ca
            link
            fedilink
            English
            arrow-up
            11
            ·
            1 month ago

            You’re both right. It’s possible to write code that gets linted well in Python, yes, but you’re often not working with just your code. If a library doesn’t use typing properly, not a lot to be done without a ton more effort.

          • FizzyOrange@programming.dev
            link
            fedilink
            arrow-up
            7
            ·
            1 month ago

            Yes because you used static type annotations. This thread was about code that doesn’t use static types (or static type annotations/hints).

            • Eiri@lemmy.ca
              link
              fedilink
              arrow-up
              1
              ·
              1 month ago

              Nope, don’t need to. WebStorm can even detect nonexistent attributes for objects whose format the back-end decides, and tbh I’m not sure what sort of sorcery it uses.

              • FizzyOrange@programming.dev
                link
                fedilink
                arrow-up
                2
                ·
                1 month ago

                Yeah IntelliJ does amazingly without type annotations but even it can’t do everything. E.g. if you’re using libraries without type annotations, or if you don’t call functions with every possible type (is your testing that good? No.)

                Static types have other benefits anyway so you should use them even if everyone in your team uses IntelliJ.

                • Eiri@lemmy.ca
                  link
                  fedilink
                  arrow-up
                  1
                  ·
                  1 month ago

                  Yeah, our company has been meaning to transition to them for a while. I started saying Jsdoc comments but people complained about the pollution. Then I said fine, we’ll do TypeScript one day instead.

                  That one day has yet to come. I don’t actually get to decide much at this company, after all. Aah, technical debt.

            • UndercoverUlrikHD@programming.dev
              link
              fedilink
              arrow-up
              3
              arrow-down
              1
              ·
              1 month ago

              OP suggested that linters for python won’t catch attribute errors, which they 100% will if you use type hints, as you should.

              What happens at runtime is really relevant in this case.

                • UndercoverUlrikHD@programming.dev
                  link
                  fedilink
                  arrow-up
                  1
                  ·
                  edit-2
                  1 month ago

                  I don’t want to get into an Internet argument over pedantry. Linter is often used as a catch-all term for static analysis tools.

                  Wikipedia defines it as

                  Lint is the computer science term for a static code analysis tool used to flag programming errors, bugs, stylistic errors and suspicious constructs.

                  Catching type errors and attribute errors would fit under this description, if you use a different, more precise definition at your workplace, cool, then we just have different definitions for it. The point is that your IDE should automatically detect the errors regardless of what you call it.

        • Strykker@programming.dev
          link
          fedilink
          arrow-up
          10
          arrow-down
          2
          ·
          1 month ago

          It’s python, just use type hinting already and your linter will catch that.

          Also some winters can look at the use of food and see the type being passed in.

          • Ephera@lemmy.ml
            link
            fedilink
            arrow-up
            15
            ·
            1 month ago

            Autocorrect got you pretty bad, there.

            I was very confused, why we’re suddenly talking about rationing food during winter. 🙃

          • FizzyOrange@programming.dev
            link
            fedilink
            arrow-up
            6
            ·
            1 month ago

            Yes you can use static type hinting and the static type checker (Mypy or Pyright) will catch that. Linters (Pylint) won’t.

        • ripcord@lemmy.world
          link
          fedilink
          arrow-up
          2
          arrow-down
          2
          ·
          1 month ago

          Not with an example that simple and poor, no.

          If you have done the minimum and at least set a type hint, or if your ide is smart enough to check what calls the function and what it passes, then it’ll be flagged.

          • Ephera@lemmy.ml
            link
            fedilink
            arrow-up
            4
            ·
            1 month ago

            How would you make it non-awful, without specifying static types?

            I guess, a unit test would catch it, but needing 100% test coverage to catch typos isn’t exactly great…

            • Ham Strokers Ejacula@reddthat.com
              link
              fedilink
              English
              arrow-up
              1
              ·
              edit-2
              1 month ago

              I would do

              class MyClass:
                  def __init__(self, value):
                      self._whatever = value
              
                  @property
                  def whatever(self):
                      return self._whatever
              

              Personally, I would type hint all of that but I’m just showing how you can do it without types. Your linter should be smart enough to say “hey dumbass did you mean this other thing”? Also since we didn’t create a setter you can’t arbitrarily overwrite the value of whatever so thats neat.

              And I’ll just say before I post that I’m on mobile and I’m sorry if the formatting is fucked. I’m not going to fix it.

          • calcopiritus@lemmy.world
            link
            fedilink
            arrow-up
            3
            ·
            edit-2
            1 month ago

            This is literally a getter function. How is a getter awful code? It’s the simplest function there is. The only function simpler than that is returning the input itself.

            • BrianTheeBiscuiteer@lemmy.world
              link
              fedilink
              arrow-up
              2
              arrow-down
              1
              ·
              1 month ago

              How does “foo” mean “get”? Half the battle of writing correct code is writing code that’s easy to interpret. Do you always look at the guts of every function you’re about to use?

            • BrianTheeBiscuiteer@lemmy.world
              link
              fedilink
              arrow-up
              2
              arrow-down
              1
              ·
              edit-2
              1 month ago

              What’s the purpose of foo? Why an ambiguous single character variable? What if the property was there but the value was null? Why not use (assuming JS) optional chaining?

              I’d approach it more like this:

              function getWhatevrProp(userData) (
                const default = { whatevr: "n/a" };
              
                return { ...default, ...userData }.whatevr;
              }
              

              Sorry, read too fast the first time. It’s more likely Python. I also don’t know Python well enough to give recommendations on that.

              • FizzyOrange@programming.dev
                link
                fedilink
                arrow-up
                3
                ·
                1 month ago

                It’s an example to demonstrate that linters cannot reliably detect variable name typos - you need static types. None of the stuff you mentioned is relevant.

                The typo in your example is also undetectable by linters. I think you’re missing the point.

  • bricked@discuss.tchncs.de
    link
    fedilink
    English
    arrow-up
    22
    ·
    1 month ago

    This literally happened to me yesterday, but with filenames. I was failing to configure a program until an hour later I found out that I mispelled the config file as colors.ini instead of color.ini.

    • Kissaki@programming.dev
      link
      fedilink
      English
      arrow-up
      8
      ·
      1 month ago

      I like that even here on Lemmy, with inline code format, colors.ini is not being colored but color.ini is. Great symbolism for your issue.

  • Ham Strokers Ejacula@reddthat.com
    link
    fedilink
    English
    arrow-up
    11
    ·
    1 month ago

    Programming has its highs and lows. Yesterday I spent four hours trying to write a script that honestly probably won’t even be useful to anyone.

    Today I felt like a god because I built a recursive query to pull some ridiculously obscure data from our database.

    Tomorrow I’ll probably delete a table in prod or something.

    You win some, you lose some!

  • ZILtoid1991@lemmy.world
    link
    fedilink
    arrow-up
    7
    ·
    1 month ago

    If you thought misspelling a variable was bad, then get ready for misreading documentation of OS API, then not realize why your implementation doesn’t work for a quite a long time.

  • Feathercrown@lemmy.world
    link
    fedilink
    English
    arrow-up
    6
    ·
    1 month ago

    I spent like 3 hours yesterday deduplicating two functions that were hundreds of lines long and nearly identical. I should probably learn how to use that git command that can diff two files on disk. Luckily I actually enjoy cleaning up code sometimes.

    • pivot_root@lemmy.world
      link
      fedilink
      arrow-up
      11
      ·
      1 month ago

      If you’re using a decent development system, you’ll have an executable called diff installed already :)

    • orbitz@lemmy.ca
      link
      fedilink
      arrow-up
      4
      ·
      1 month ago

      Dunno what OS’s it supports besides Windows but I use Kdiff for random comparisons regularly, I think it works pretty well untill you get to much larger files (20+ MB slows down a lot). The huge file wasn’t code but needed to check output changes for those curious.

      I constantly check git comparison with previous versions to see what changed to break things in a build though. Didn’t know there was a way to diff any files in git,should probably just learn to use that one.

      • Ephera@lemmy.ml
        link
        fedilink
        arrow-up
        3
        ·
        1 month ago

        Git uses the diff binary under the hood (unless you configure it to use something else).
        You can invoke that directly with diff file_a.txt file_b.txt.

    • egrets@lemmy.world
      link
      fedilink
      arrow-up
      4
      arrow-down
      1
      ·
      1 month ago

      VS Code’s diff tools are killer. Comparison is smarter than most, and you can edit either file as you go.

      • wizardbeard@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        4
        ·
        1 month ago

        And if you want to avoid the Microsoft stank, there’s VS Codium that has been de-Microsoft’d, like Chrome vs. Chromium.

    • hayes_@sh.itjust.works
      link
      fedilink
      arrow-up
      2
      ·
      1 month ago

      git diff —no-index before.json after.json > showmethegoods.diff

      You don’t have to save it to a file but I often do.

  • Clinicallydepressedpoochie@lemmy.world
    link
    fedilink
    arrow-up
    5
    ·
    edit-2
    1 month ago

    The older I get the more impatient I get with stupid tasks that take longer then they should. I simplify my life by focusing on the task ahead of me. Knowing these small tasks compound into the final goal.

    So when I am looking through 17 different folders for a file I can’t remember what I saved it as and I’m sorting by date and opening things frantically…

    ‘it’s been 20 fucking minutes, should I just take the rest of the day to organize my shit? But if I get this fucking thing done I can setup a meeting on this today and fit it in this week before Juan goes on vacation and I have to wait two weeks to place an order that will take 6 months to deliver.’

    ‘Fuuuuuuuuu where the fuck is this file, I’ll just start from scratch and I’ll be done by 2pm just in time for it to go on the calender so everyone can seee. Or maybe i just look another 15 minutes wheeerreeeee the fuckkkk did I save this?!?!’

    'Bullshit bullshit bullshit!"

    Google: how to find file.

    Google: how to find file just working on.

    Google: how to find excel file by date, most recent.

    Google: file not in recent, why come?

    Google: did I dream this nightmare wake me, wake me, wake me.’

  • grudan@programming.dev
    link
    fedilink
    arrow-up
    3
    ·
    1 month ago

    I spent such a long time the other day trying to figure out why I couldn’t access an application I wrote and served on a home server from my reverse proxy. Next day I take a look at the DNS record I setup again, CNAMEd to the host server instead of the reverse proxy server. Felt dumb.